Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ModuleNotFoundError with the more general ImportError #2441

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 19, 2023

Description of proposed changes

ref: https://stackoverflow.com/questions/62854761/

Fixes #2436.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Mar 19, 2023
pygmt/datasets/tile_map.py Outdated Show resolved Hide resolved
@seisman seisman added this to the 0.9.0 milestone Mar 21, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 21, 2023
@seisman
Copy link
Member Author

seisman commented Mar 22, 2023

Ping @weiji14 Are you OK with the changes?

@seisman seisman merged commit ae933fa into main Mar 22, 2023
@seisman seisman deleted the use-importerr branch March 22, 2023 02:54
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError vs ModuleNotFoundError
3 participants