New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pygmt.select: Add aliases for "C", "F", and "L" #2466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnefroehlich
changed the title
pygmt.select: Add aliases for C, F, and L
WIP: pygmt.select: Add aliases for C, F, and L
Mar 29, 2023
yvonnefroehlich
changed the title
WIP: pygmt.select: Add aliases for C, F, and L
WIP: pygmt.select: Add aliases for "C", "F", and "L"
Mar 31, 2023
/format |
7 tasks
yvonnefroehlich
commented
Aug 27, 2023
yvonnefroehlich
added
the
needs review
This PR has higher priority and needs review.
label
Aug 27, 2023
yvonnefroehlich
changed the title
WIP: pygmt.select: Add aliases for "C", "F", and "L"
pygmt.select: Add aliases for "C", "F", and "L"
Aug 27, 2023
michaelgrund
approved these changes
Aug 29, 2023
weiji14
reviewed
Aug 29, 2023
weiji14
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yvonnefroehlich!
weiji14
added
final review call
This PR requires final review and approval from a second reviewer
and removed
needs review
This PR has higher priority and needs review.
labels
Aug 30, 2023
weiji14
added a commit
that referenced
this pull request
Aug 31, 2023
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR aims to add aliases for
pygmt.select
:pointfile
dist2pt
polygonfile
polygon
line_file
dist2line
The aliases are currently based on the Julia documentation at
https://joa-quim.github.io/GMTjl_doc/documentation/modules/gmtselect/index.html.
Preview: https://pygmt-dev--2466.org.readthedocs.build/en/2466/api/generated/pygmt.select.html
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version