Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Web WorldWind support #275

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Remove Web WorldWind support #275

merged 1 commit into from
Jan 24, 2019

Conversation

leouieda
Copy link
Member

It was always kind of flaky and is now broken on the docs and in Jupyter
Lab. We can try better version of this later on. Right now, it's not
easy to test and maintain and shouldn't be in the code base.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

It was always kind of flaky and is now broken on the docs and in Jupyter
Lab. We can try better version of this later on. Right now, it's not
easy to test and maintain and shouldn't be in the code base.
@leouieda leouieda merged commit 7e18838 into master Jan 24, 2019
@leouieda leouieda deleted the worldwind branch January 24, 2019 13:52
leouieda pushed a commit that referenced this pull request Jan 24, 2019
The files are no longer needed in the docs HTML after #275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant