Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the PDF format documentation in the ReadTheDocs site #2876

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 13, 2023

Description of proposed changes

This PR enables the PDF documentation in the ReadTheDocs builds. This is the initial and simple effort to address the request in #1606.

After merging the changes into the main branch (PDFs are disabled in PR previews), we will see a PDF download link at the bottom of the sidebar on the ReadTheDocs site (https://pygmt-dev.readthedocs.io/), as shown below:

image

The screenshot above comes from the PyGMT documentation site built from my own PyGMT fork. The full URL of the site is https://pygmt-test.readthedocs.io/en/latest/, and the direct URL of PDF file is https://pygmt-test.readthedocs.io/_/downloads/en/latest/pdf/.

As you can see, the layout of the PDF documentation is not ideal, but at least it includes everything, and is still useful for offline use.

If approved and merged, I think we should post the link to the PDF documentation in issue #1606 so that users can easily find the PDF file.

@seisman seisman changed the title Enable the PDF format in the ReadTheDocs builds RFC: Enable the PDF format in the ReadTheDocs builds Dec 13, 2023
@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Dec 13, 2023
@seisman seisman added this to the 0.11.0 milestone Dec 13, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Dec 14, 2023
@seisman seisman changed the title RFC: Enable the PDF format in the ReadTheDocs builds Enable the PDF format in the ReadTheDocs builds Dec 14, 2023
@seisman seisman changed the title Enable the PDF format in the ReadTheDocs builds Enable the PDF format documentation in the ReadTheDocs builds Dec 14, 2023
@seisman seisman changed the title Enable the PDF format documentation in the ReadTheDocs builds Enable the PDF format documentation in the ReadTheDocs site Dec 14, 2023
@seisman seisman merged commit c15014a into main Dec 14, 2023
16 of 17 checks passed
@seisman seisman deleted the readthedocs/pdf branch December 14, 2023 09:22
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants