Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyarrow: Check compatibility of pyarrow.array with string type #2933

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Dec 30, 2023

Description of proposed changes

Check that pyarrow.array objects of string type can be passed to PyGMT modules/functions.

TODO:

  • Initial compatibility check of pyarrow.array by adding parametrized tests to pygmt.text
  • Add parametrized test to test_virtualfile_from_vectors.py
  • Check that pa.StringArray can be passed into put_strings?
  • etc

Addresses #2800 (comment), part of #2800.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Ensure that pyarrow.array objects with string type can be read by pygmt.text.
@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Dec 30, 2023
@weiji14 weiji14 added this to the 0.11.0 milestone Dec 30, 2023
@weiji14 weiji14 self-assigned this Dec 30, 2023
@seisman seisman modified the milestones: 0.11.0, 0.12.0 Feb 1, 2024
@seisman seisman removed this from the 0.12.0 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants