Update output shape and mean values from some x2sys_cross tests #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that the modified tracks won't be used in other test functions, causing tests to fail.
Small changes to the number of output rows, and the mean value of the z_X and z_M/z_1/z_2 columns.
weiji14
commented
Jan 11, 2024
Comment on lines
+146
to
+148
| newtracks = copy.deepcopy(x=tracks) | ||
| newtracks[0].loc[newtracks[0]["z"] < -15, "z"] = np.nan # set some NaN values | ||
| output = x2sys_cross(tracks=newtracks, tag=tag, coe="i") |
Comment on lines
66
to
+69
| output = x2sys_cross(tracks=["@tut_ship.xyz"], tag=tag, coe="i") | ||
|
|
||
| assert isinstance(output, pd.DataFrame) | ||
| assert output.shape == (14294, 12) | ||
| assert output.shape == (14338, 12) |
There was a problem hiding this comment.
Still a little unsure why GMT 6.5.0's x2sys_cross returns more rows than GMT 6.4.0. Might need to investigate.
|
Haven't got time to check whether the change in output shape from |
seisman
approved these changes
Jan 16, 2024
The |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Small changes to the number of output rows, and the mean value of the z_X and z_M/z_1/z_2 columns.
Also for
test_x2sys_cross_input_dataframe_with_nan, a deep copy of thetracks: list[pd.DataFrame]object is now made before NaN values are set, to avoid some test flakiness.Addresses #2961 (comment)
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code