Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt SPEC 0 policy and drop NEP 29 policy #3037

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Adopt SPEC 0 policy and drop NEP 29 policy #3037

merged 6 commits into from
Feb 5, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Feb 3, 2024

The NEP 29 policy is superseded by the SPEC 0 policy.

Address #2863.

@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Feb 3, 2024
@seisman seisman added this to the 0.12.0 milestone Feb 3, 2024
@seisman seisman requested a review from a team February 5, 2024 00:54
Comment on lines 1 to 2
Minimum Supported GMT/Python/NumPy Versions
-------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be too long?

Suggested change
Minimum Supported GMT/Python/NumPy Versions
-------------------------------------------
Minimum Supported GMT/Python/NumPy/Pandas/Xarray Versions
---------------------------------------------------------

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "Minimum Supported Versions" is enough.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to "Minimum Supported Versions" in f4049a0.

doc/minversions.rst Outdated Show resolved Hide resolved
doc/maintenance.md Outdated Show resolved Hide resolved
doc/maintenance.md Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
.github/workflows/ci_tests.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_checklist.md Outdated Show resolved Hide resolved
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
doc/maintenance.md Outdated Show resolved Hide resolved
doc/maintenance.md Outdated Show resolved Hide resolved
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Feb 5, 2024
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
doc/maintenance.md Outdated Show resolved Hide resolved
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Comment on lines +8 to 11
* Support for core package dependencies (NumPy/Pandas/Xarray) be dropped 2 years after their initial release.

.. list-table::
:widths: 25 30 15 20 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add columns for Pandas and Xarray in this PR, or in a follow up PR?

@seisman seisman merged commit 7e1389f into main Feb 5, 2024
14 of 17 checks passed
@seisman seisman deleted the spec0 branch February 5, 2024 23:49
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 5, 2024
seisman added a commit to seisman/pygmt that referenced this pull request Feb 19, 2024
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
weiji14 added a commit that referenced this pull request May 1, 2024
seisman pushed a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants