clib: Rename the virtualfile_from_data method to virtualfile_in #3068
Conversation
seisman
added
deprecation
seisman
changed the title
seisman
changed the title
seisman
added
final review call
seisman
removed
the
final review call
| # virtualfile_from_data was renamed to virtualfile_in since v0.12.0. | ||
| virtualfile_from_data = virtualfile_in |
There was a problem hiding this comment.
Originally posted by @yvonnefroehlich in #3180 (comment)
Regarding the point
* clib: Rename the "virtualfile_from_data" method to "virtualfile_in" ([#3068](https://github.com/GenericMappingTools/pygmt/pull/3068))I was / am a bit unsure, as there ins no FutureWarning added and not version stated when
virtualfile_from_datais removed.
@seisman, did you want to keep this virtualfile_from_data alias around, or remove it at some point? If removing, should we start to raise a FutureWarning in v0.13.0, and remove it completely in v0.15.0?
There was a problem hiding this comment.
If removing, should we start to raise a FutureWarning in v0.13.0, and remove it completely in v0.15.0?
Sounds good
There was a problem hiding this comment.
This is also fine with me.
I have added this to the changelog for v0.12.0; feel free to remove it if you think it is better not to state it before we have implemented it.
Rename
virtualfile_from_datatovirtualfile_in. The old name is still supported but will be removed in the future.Address #3057 (comment)