Session.virtualfile_to_dataset: Add 'strings' output type for the array of trailing texts #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
enhancement
…ay of trailing texts
seisman
force-pushed
the
dataset/to_strings
branch
from
d9d2f9b
to
2442fda
Compare
seisman
commented
Apr 3, 2024
seisman
commented
Apr 3, 2024
| @@ -1841,6 +1842,16 @@ def virtualfile_to_dataset( | |||
| ... assert result is None | |||
| ... assert Path(outtmp.name).stat().st_size > 0 | |||
| ... | |||
| ... # strings output | |||
There was a problem hiding this comment.
Maybe I should move all the doctests except the pandas one into the separate test_clib_virtualfile.py file since the docstrings are too long.
Edit: Not as easy as I initially thought. So I'll keep them in the docstrings now.
seisman
added
final review call
seisman
removed
the
final review call
|
Self-approved and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Address #3148 (comment).
Two main changes:
_GMT_DATASET.to_stringsmethod which returns an array of the trailing textoutput_type="strings"toSession.virtualfile_to_datasetwhich wraps the_GMT_DATASET.to_stringsmethodTests are also added. The method name
.to_stringsis similar topd.DataFrame.to_string, but since we return an array of strings, we useto_stringsinstead ofto_string.