Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Figure.plot: Add alias "fillcurves" for "M" #3169

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Apr 14, 2024

Description of proposed changes

This PR aims to add an alias for M of plot (new in GMT 6.5.0).
Sofar I used fillcurves, but @GenericMappingTools/gmt-maintainers feel free to make suggestions for another / a better alias 馃檪.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added the enhancement Improving an existing feature label Apr 14, 2024
@yvonnefroehlich yvonnefroehlich added this to the 0.12.0 milestone Apr 14, 2024
@yvonnefroehlich yvonnefroehlich self-assigned this Apr 14, 2024
@yvonnefroehlich
Copy link
Member Author

/format

@yvonnefroehlich
Copy link
Member Author

/format

@seisman
Copy link
Member

seisman commented Apr 15, 2024

This reminds me the fill_between method in matplotlib, so another high-level method for Figure.plot. I guess we need to focus on #2797 in PyGMT v0.13.0.

@yvonnefroehlich
Copy link
Member Author

This reminds me the fill_between method in matplotlib, so another high-level method for Figure.plot. I guess we need to focus on #2797 in PyGMT v0.13.0.

You are probably right, and a high-level method would be more user-friendly and more Pythonic. Despite this, should I still continue working on adding an alias for M or should we close this PR and the PR for the related gallery example?

@seisman
Copy link
Member

seisman commented Apr 18, 2024

This reminds me the fill_between method in matplotlib, so another high-level method for Figure.plot. I guess we need to focus on #2797 in PyGMT v0.13.0.

You are probably right, and a high-level method would be more user-friendly and more Pythonic. Despite this, should I still continue working on adding an alias for M or should we close this PR and the PR for the related gallery example?

Personally I prefer to have v0.12.0 released soon and then focus on improving Figure.plot/Figure.plot3d and implementing the proposed high-level wrappers (#2797) in v0.13.0. With the new wrappers, the gallery examples you're working on can be greatly simplified.

@yvonnefroehlich
Copy link
Member Author

This reminds me the fill_between method in matplotlib, so another high-level method for Figure.plot. I guess we need to focus on #2797 in PyGMT v0.13.0.

You are probably right, and a high-level method would be more user-friendly and more Pythonic. Despite this, should I still continue working on adding an alias for M or should we close this PR and the PR for the related gallery example?

Personally I prefer to have v0.12.0 released soon and then focus on improving Figure.plot/Figure.plot3d and implementing the proposed high-level wrappers (#2797) in v0.13.0. With the new wrappers, the gallery examples you're working on can be greatly simplified.

I agree that we should focus to get v0.12.0 out soon (even if I can not state how much I can help out in the next time).
I converted the PRs for the "stem plot" (#3052) and "filled curves" (#3168) gallery examples to drafts.

@yvonnefroehlich yvonnefroehlich marked this pull request as draft April 18, 2024 21:07
@seisman seisman modified the milestones: 0.12.0, 0.13.0 Apr 19, 2024
@seisman seisman removed this from the 0.13.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants