Reorganize the list of data files for caching #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
changed the title
weiji14
reviewed
Apr 16, 2024
pygmt/helpers/caching.py
Outdated
| @@ -100,4 +89,5 @@ def cache_data(): | |||
| "@tut_ship.xyz", | |||
| "@usgs_quakes_22.txt", | |||
| ] | |||
| which(fname=datasets, download="a") | |||
|
|
|||
| which(fname=datasets + caches + tiles, download="a") | |||
There was a problem hiding this comment.
Can we continue to use just a single list?
There was a problem hiding this comment.
We can. I just feel that having three separate lists makes it easier to organize the file list.
There was a problem hiding this comment.
Well, codecov is warning that there's missing code coverage for the extra two lists 🙂
There was a problem hiding this comment.
That's a good point to push me to merge them into a single list.
weiji14
reviewed
Apr 17, 2024
pygmt/helpers/caching.py
Outdated
| @@ -100,4 +89,5 @@ def cache_data(): | |||
| "@tut_ship.xyz", | |||
| "@usgs_quakes_22.txt", | |||
| ] | |||
| which(fname=datasets, download="a") | |||
|
|
|||
| which(fname=datasets + caches + tiles, download="a") | |||
There was a problem hiding this comment.
Well, codecov is warning that there's missing code coverage for the extra two lists 🙂
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
Apr 17, 2024
seisman
added
final review call
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a likely upstream bug, we can't request multiple tiled grids in a singlewhichcall (xref: #3170). We have to callwhichmultiple times and download a single tiled grid in each call, to make the "Cache data" workflow pass again.I also take this opportunity to address the request in #3144.Closes #3144.
Edit: With the workaround in PR #3174, now it's OK to download multiple tiled grids. So, this PR only reorganize the list of data files for caching to make it easy to maintain.