Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing in list to 'region' argument in surface #378

Merged
merged 1 commit into from Nov 9, 2019

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Nov 9, 2019

Description of proposed changes

Allows users to pass in a Python list to region (e.g. region=[245, 255, 20, 30]) instead of having to do region="245/255/20/30" in the surface module.

Fixes #347

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@weiji14 weiji14 merged commit d2135dc into master Nov 9, 2019
@weiji14 weiji14 deleted the surface/region_list branch November 9, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing in a list to 'region' in surface doesn't work
2 participants