Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update baseline images for updates of earth relief data #452

Merged
merged 5 commits into from
May 25, 2020
Merged

Update baseline images for updates of earth relief data #452

merged 5 commits into from
May 25, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented May 24, 2020

Description of proposed changes

See #451 for context.

Fixes #451.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman marked this pull request as ready for review May 25, 2020 01:37
@seisman seisman requested a review from weiji14 May 25, 2020 01:37
@seisman seisman added the maintenance Boring but important stuff for the core devs label May 25, 2020
weiji14
weiji14 approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @seisman!

@seisman
Copy link
Member Author

seisman commented May 25, 2020

Anything should I do to make the release drafter happy?

@weiji14
Copy link
Member

weiji14 commented May 25, 2020

Anything should I do to make the release drafter happy?

You've tagged this as maintenance so it should work automatically, but we should merge #446 first.

@seisman
Copy link
Member Author

seisman commented May 25, 2020

OK, let's wait for #446.

@seisman seisman merged commit 38051cf into master May 25, 2020
@seisman seisman deleted the baseline-updates branch May 25, 2020 05:40
@seisman seisman added this to the 0.2.x milestone May 25, 2020
@weiji14 weiji14 modified the milestones: 0.2.x, 0.1.x Jun 29, 2020
@weiji14 weiji14 mentioned this pull request Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.1.x
Development

Successfully merging this pull request may close these issues.

Baseline images need updates due to the recent updates of earth relief data
2 participants
@seisman @weiji14