Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the instructions for testing pygmt install #459

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented May 25, 2020

Description of proposed changes

  • Clean up unnecessary packages for testing. Only pytest, pytest-mpl and ipython are needed
  • Add pygmt.print_clib_info() for testing

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

- Clean up unnecessary packages for testing. Only pytest, pytest-mpl and ipython are needed
- Add `pygmt.print_clib_info()` for testing
@seisman seisman added the documentation Improvements or additions to documentation label May 25, 2020
@seisman seisman added this to the 0.2.x milestone May 25, 2020
@seisman seisman requested a review from weiji14 May 25, 2020 11:02
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had time to test this locally but should be fine 🤞. Should supplement/replace pygmt.print_clib_versions() with pygmt.show_versions() once #460 is resolved.

@seisman seisman added this to In progress in Release v0.2.x via automation May 26, 2020
@seisman seisman merged commit 52c2d13 into master May 26, 2020
Release v0.2.x automation moved this from In progress to Done May 26, 2020
@seisman seisman deleted the update-install branch May 26, 2020 03:33
@weiji14 weiji14 modified the milestones: 0.2.x, 0.1.x Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants