Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "no_clip" to plot, text, contour and meca #661

Merged
merged 4 commits into from Oct 23, 2020
Merged

Add "no_clip" to plot, text, contour and meca #661

merged 4 commits into from Oct 23, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 22, 2020

Description of proposed changes

This PR adds the no_clip argument (alias of -N) to plot, text, countour and meca.

The name no_clip was agreed when wrapping the grdimage method in #620 (comment)

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman added the documentation Improvements or additions to documentation label Oct 22, 2020
@seisman seisman added this to In progress in Release v0.2.x via automation Oct 22, 2020
@seisman seisman added this to the 0.2.1 milestone Oct 22, 2020
@seisman seisman requested a review from weiji14 October 22, 2020 15:58
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, otherwise fine.

On a related note, should probably improve the documentation of plot at https://www.pygmt.org/v0.2.0/api/generated/pygmt.Figure.plot.html#pygmt.Figure.plot since it's quite widely used. I was going to do it in #471 but might be better to have a separate PR handling it specifically.

pygmt/base_plotting.py Outdated Show resolved Hide resolved
pygmt/base_plotting.py Outdated Show resolved Hide resolved
pygmt/base_plotting.py Outdated Show resolved Hide resolved
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, good to merge. The macOS test breakages seem unrelated, not sure why there's a segmentation fault on the xarray shading test?

@seisman
Copy link
Member Author

seisman commented Oct 23, 2020

The macOS test breakages seem unrelated, not sure why there's a segmentation fault on the xarray shading test?

In PR #650, I added more tests for xarray shading. These tests work well for GMT master, but not for 6.1.1. Perhaps some of the tests have segmentation faults with GMT 6.1.1.

@seisman seisman merged commit 2c977f5 into master Oct 23, 2020
Release v0.2.x automation moved this from In progress to Done Oct 23, 2020
@seisman seisman deleted the no_clip branch October 23, 2020 00:54
@weiji14 weiji14 mentioned this pull request Oct 23, 2020
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants