Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Makefile target 'distclean' for deleting project metadata files #744

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 17, 2020

Description of proposed changes

See #737 for context.

Changes in this PR:

  1. Do NOT delete the *.egg-info directory for make clean
  2. Delete .pytest_cache (pytest cache files)
  3. Add make distclean to delete all generated files and *.egg-info directory
  4. Use similar syntax for the find commands

Fixes #737.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

@seisman seisman changed the title Add a new target 'distclean' for delete project metadata files Add a new Makefile target 'distclean' for delete project metadata files Dec 17, 2020
@seisman seisman changed the title Add a new Makefile target 'distclean' for delete project metadata files Add a Makefile target 'distclean' for deleting project metadata files Dec 17, 2020
@seisman seisman requested a review from a team December 17, 2020 20:53
@seisman seisman added the maintenance Boring but important stuff for the core devs label Dec 17, 2020
@seisman seisman added this to the 0.3.0 milestone Dec 17, 2020
@seisman seisman merged commit 97869e2 into master Dec 18, 2020
@seisman seisman deleted the make-distclean branch December 18, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "make clean"
2 participants