Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docstrings of common aliases #862

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Feb 11, 2021

Description of proposed changes

Update the docstrings of common aliases following the convenction in #631.

This PR is different from PR #783.

I feel that the changes in PR #783 make COMMON_OPTIONS difficult to read:

PR #783 This PR
image image

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman marked this pull request as draft February 11, 2021 22:47
@seisman seisman changed the title Update the documentation of common aliases Update the docstrings of common aliases Feb 12, 2021
@seisman seisman added the documentation Improvements or additions to documentation label Feb 12, 2021
@seisman seisman added this to the 0.3.0 milestone Feb 12, 2021
@seisman seisman force-pushed the common-options-aliases branch 3 times, most recently from f48cb83 to 692f167 Compare February 12, 2021 00:38
@seisman seisman marked this pull request as ready for review February 12, 2021 01:14
@seisman
Copy link
Member Author

seisman commented Feb 12, 2021

This PR is ready for review, but it seems something wrong with Vercel, so the documentation is not available for preview yet.

@willschlitzer
Copy link
Contributor

I agree that my pull request (#783) makes the code hard to read!

Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It seems to have deployed fine, and I checked at least one page for each of the aliases with no issues.

@willschlitzer willschlitzer merged commit b8385bf into master Feb 12, 2021
@willschlitzer willschlitzer deleted the common-options-aliases branch February 12, 2021 07:02
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Update the docstrings of the aliases in COMMON_OPTIONS in decorators.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants