Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog entry for v0.3.0 #887

Merged
merged 22 commits into from
Feb 15, 2021
Merged

Changelog entry for v0.3.0 #887

merged 22 commits into from
Feb 15, 2021

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Feb 14, 2021

Description of proposed changes

Preview: https://pygmt-git-v030-release.gmt.vercel.app/changes.html

Previous release at #683

Changelog made by following the instructions at https://github.com/GenericMappingTools/pygmt/blob/master/MAINTENANCE.md#updating-the-changelog. The changelog itself includes the following sections:

  • New features
  • Enhancements
  • Documentation
  • Bug fixes
  • Maintenance
  • List of Contributors

TODO:

  • Format Pull Request links using sed -i.bak -E 's$\(#([0-9]*)\)$(`#\1 <https://github.com/GenericMappingTools/pygmt/pull/\1>`__)$g' changes.rst
  • Add Zenodo DOI link once it's reserved.
  • Add a new entry in doc/_static/version_switch.js for documentation switcher
  • Update citation information https://github.com/GenericMappingTools/pygmt#citing-pygmt
  • Set release date

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the skip-changelog Skip adding Pull Request to changelog label Feb 14, 2021
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @willschlitzer, assuming that you're learning from the previous release PR at #683 already. if you don't mind, could you edit the top post to follow that style (with checkboxes and all). We'll probably turn it into a proper template for #885 next time.

image

README.rst Show resolved Hide resolved
@weiji14 weiji14 added this to the 0.3.0 milestone Feb 14, 2021
@weiji14
Copy link
Member

weiji14 commented Feb 14, 2021

Oh and by the way, I see that you've cleaned up the draft release notes at https://github.com/GenericMappingTools/pygmt/releases. Make sure you have a local backup, otherwise the release drafter bot will override your changes when we merge the last few PRs remaining for v0.3.0.

@willschlitzer
Copy link
Contributor Author

willschlitzer commented Feb 14, 2021

@weiji14 It's backed up!

README.rst Outdated Show resolved Hide resolved
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@weiji14 weiji14 mentioned this pull request Feb 14, 2021
19 tasks
@weiji14 weiji14 changed the title V0.3.0 release Changelog entry for v0.3.0 Feb 14, 2021
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
doc/changes.rst Outdated

Highlights

*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add 3 to 4 lines for the highlights section here. How about:

Suggested change
*
* 🎉 **Third minor release of PyGMT** 🎉
* Wrap inset (#788) for making overview maps and subplot (#822) for multi-panel figures
* Apply standardized formatting conventions (#775) across most documentation pages
* Drop Python 3.6 support (#699) so PyGMT now requires Python 3.7 or newer

Feel free to suggest edits in the wording. I'm also thinking whether to mention the upcoming drop in support for GMT 6.1.1 (once GMT 6.2.0 is out, something for PyGMT v0.4.0) and/or NEP29 adoption (#690). Might depend on whether we want a v0.3.1 release?

Copy link
Member

@seisman seisman Feb 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also thinking whether to mention the upcoming drop in support for GMT 6.1.1 (once GMT 6.2.0 is out, something for PyGMT v0.4.0) and/or NEP29 adoption

Don't try to predict the future. 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will surprise our users then 😸

doc/changes.rst Outdated

Contributors

@liamtoney, @meghanrjones, @michaelgrund, @seisman, @weiji14 and @willschlitzer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@liamtoney, @meghanrjones, @michaelgrund, @seisman, @weiji14 and @willschlitzer
People with a "+" by their name contributed a patch for the first time.
* `Dongdong Tian <https://github.com/seisman>`__
* `Liam Toney <https://github.com/liamtoney>`__
* `Meghan Jones <https://github.com/meghanrjones>`__ +
* `Michael Grund <https://github.com/michaelgrund>`__ +
* `Wei Ji Leong <https://github.com/weiji14>`__
* `Will Schlitzer <https://github.com/willschlitzer>`__ +

Two thoughts here:

  1. Should we sort alphebetically by name (as above), or by number of commits (old style before).
  2. Some projects (e.g. geopandas) add a little note with a plus (+) to indicate people's first contribution, should we add it here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two thoughts here:

  1. Should we sort alphebetically by name (as above), or by number of commits (old style before).

I'm fine with both, but prefer "number of commits".

  1. Some projects (e.g. geopandas) add a little note with a plus (+) to indicate people's first contribution, should we add it here?

I saw it in many projects, but is there an easy way to know if someone makes his/her first contribution to this release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Some projects (e.g. geopandas) add a little note with a plus (+) to indicate people's first contribution, should we add it here?

I saw it in many projects, but is there an easy way to know if someone makes his/her first contribution to this release?

Other than remembering people, there's probably a complicated git command that could do it. Happy to leave it without the plus.

I'm fine with both, but prefer "number of commits".

I thought your name would be on top either way, but git shortlog HEAD...v0.2.1 -sne gives:

    58  Will Schlitzer <schlitzer90@gmail.com>
    54  Dongdong Tian <seisman.info@gmail.com>
     9  Wei Ji <23487320+weiji14@users.noreply.github.com>
     7  Michael Grund <michael_grund@gmx.de>
     6  dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
     3  Liam Toney <38269494+liamtoney@users.noreply.github.com>
     3  Meghan Jones <meghanj@hawaii.edu>
     3  Wei Ji <weiji.leong@vuw.ac.nz>

and so the order would be:

Suggested change
@liamtoney, @meghanrjones, @michaelgrund, @seisman, @weiji14 and @willschlitzer
* `Will Schlitzer <https://github.com/willschlitzer>`__
* `Dongdong Tian <https://github.com/seisman>`__
* `Wei Ji Leong <https://github.com/weiji14>`__
* `Michael Grund <https://github.com/michaelgrund>`__
* `Liam Toney <https://github.com/liamtoney>`__
* `Meghan Jones <https://github.com/meghanrjones>`__

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll commit the change, but we should document this (order by number of commits) for when we deal with #885.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running git shortlog HEAD...v0.2.1 -sne on the master branch gives me:

    54  Dongdong Tian <seisman.info@gmail.com>
    54  Will Schlitzer <schlitzer90@gmail.com>
     9  Wei Ji <23487320+weiji14@users.noreply.github.com>
     7  Michael Grund <michael_grund@gmx.de>
     6  dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
     3  Liam Toney <38269494+liamtoney@users.noreply.github.com>
     3  Meghan Jones <meghanj@hawaii.edu>

Not trying to be listed at the top, just curious why our results are different 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I was probably on a different branch (which explains why it had my unversity vuw.ac.nz email). I think you'll get bumped down after @willschlitzer merges this PR though 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dare I suggest that as a GMT developer and long-time PyGMT maintainer, I think @seisman has definitely earned the first spot!

doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
@weiji14
Copy link
Member

weiji14 commented Feb 15, 2021

Format Pull Request links using sed -i.bak -E 's$(#([0-9]*))$(#\1 <https://github.com/GenericMappingTools/pygmt/pull/\1>__)$g' changes.rst

Also, are you able to run sed? If not I can do it for you.

@willschlitzer
Copy link
Contributor Author

Format Pull Request links using sed -i.bak -E 's$(#([0-9]*))$(#\1 <https://github.com/GenericMappingTools/pygmt/pull/\1>__)$g' changes.rst

Also, are you able to run sed? If not I can do it for you.

Forgot about that one! Just ran it and pushed the change

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, manually updating two lines for now to be comma (,) separated, because I can't be bothered to learn sed in a rush. Hopefully this is the last 🤞

doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@willschlitzer
Copy link
Contributor Author

Ok, manually updating two lines for now to be comma (,) separated, because I can't be bothered to learn sed in a rush. Hopefully this is the last crossed_fingers

Hoping for that too!

doc/changes.rst Outdated Show resolved Hide resolved
@weiji14 weiji14 merged commit 65b099a into master Feb 15, 2021
@weiji14 weiji14 deleted the v0.3.0-release branch February 15, 2021 09:23
@weiji14 weiji14 restored the v0.3.0-release branch February 15, 2021 11:42
weiji14 added a commit that referenced this pull request Feb 15, 2021
Third minor release of PyGMT.

* Add v0.3.0 to version_switch.js
* Update citation information
* Update compatibility and documentation links
* Initial draft changelog from Release Drafter
* Merge some changelog entries together
* Add highlights and list out contributor names ordered by no. of commits
* Group changes in the "Maintenance" section
* Group changes in the 'Documentation' section and update some titles
* Run sed command to format links; format fixes

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Will Schlitzer <willschlitzer@users.noreply.github.com>
@weiji14 weiji14 deleted the v0.3.0-release branch February 15, 2021 11:56
weiji14 added a commit that referenced this pull request Feb 15, 2021
Third minor release of PyGMT.

* Add v0.3.0 to version_switch.js
* Update citation information
* Update compatibility and documentation links
* Initial draft changelog from Release Drafter
* Merge some changelog entries together
* Add highlights and list out contributor names ordered by no. of commits
* Group changes in the "Maintenance" section
* Group changes in the 'Documentation' section and update some titles
* Run sed command to format links; format fixes

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Will Schlitzer <willschlitzer@users.noreply.github.com>
@weiji14 weiji14 mentioned this pull request Mar 9, 2021
23 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Third minor release of PyGMT.

* Add v0.3.0 to version_switch.js
* Update citation information
* Update compatibility and documentation links
* Initial draft changelog from Release Drafter
* Merge some changelog entries together
* Add highlights and list out contributor names ordered by no. of commits
* Group changes in the "Maintenance" section
* Group changes in the 'Documentation' section and update some titles
* Run sed command to format links; format fixes

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Will Schlitzer <willschlitzer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants