Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write changelog in markdown using MyST #941

Merged
merged 8 commits into from
Feb 22, 2021
Merged
19 changes: 11 additions & 8 deletions .github/release-drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,29 @@ categories:
label: 'feature'
- title: 'Enhancements'
label: 'enhancement'
- title: 'Documentation'
label: 'documentation'
- title: 'Deprecations'
label: 'deprecation'
- title: 'Bug Fixes'
label: 'bug'
- title: 'Documentation'
label: 'documentation'
- title: 'Maintenance'
label: 'maintenance'
- title: 'Deprecations'
label: 'deprecation'
Comment on lines -8 to -15
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Categories have been reordered following #885 (comment). Do we want to reorder things in the previous release changelogs (i.e. v0.1.0 to v0.3.0) or just keep them as they were?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Categories have been reordered following #885 (comment).

Looks good to me.

Do we want to reorder things in the previous release changelogs (i.e. v0.1.0 to v0.3.0) or just keep them as they were?

No need to reorder the old entries.

exclude-labels:
- 'skip-changelog'
change-template: '* $TITLE (#$NUMBER)'
category-template: '### $TITLE'
Copy link
Member Author

@weiji14 weiji14 Feb 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need help to find a way to make the subheaders (e.g. for v0.2.1 enhancements) a proper permalink. I.e. something like https://pygmt-git-myst-changelog.gmt.vercel.app/changes.html#v0-2-1-enhancements instead of https://pygmt-git-myst-changelog.gmt.vercel.app/changes.html#id3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems commonmark still doesn't support anchors for headers, so maybe we can do nothing here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autosectionlabel_prefix_document configuration variable can be used to make headings which appear multiple times but in different documents unique.

Useful for avoiding ambiguity when the same section heading appears in different documents.

I don't think it works for us.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiji14 As we have no solution for the custom anchors, do you think we should not use h3 headers, but just use bold headings, i.e., use **Documentation**, not ### Documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would stick with h3 headers. Even without the permalink anchors, it'll still be easier for users to navigate quickly to the subsection on the sidebar:

Changelog subsections in navbar

And people could still point to the v0.3.0 highlights using https://www.pygmt.org/v0.3.0/changes.html#highlights, and so on for v0.4.0 and beyond.

change-template: '* $TITLE ([#$NUMBER]($URL))'
template: |
[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.3781524.svg)](https://doi.org/10.5281/zenodo.3781524)
## Release v$NEXT_PATCH_VERSION (20YY/MM/DD)

[![Digital Object Identifier for PyGMT v$NEXT_PATCH_VERSION](https://zenodo.org/badge/DOI/10.5281/zenodo.3781524.svg)](https://doi.org/10.5281/zenodo.3781524)
weiji14 marked this conversation as resolved.
Show resolved Hide resolved

## Highlights
### Highlights

*

$CHANGES

## Contributors
### Contributors

$CONTRIBUTORS