-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent file format of images for remote datasets #104
Comments
Well here there are two issues. 1. Two types of images (jpg and png)The idea of both types is that I checked (when I did #95) both types of images and I choose the smaller one (based of size). For example, you can see that GMT_earth_mask.jpg is 53,7 KiB and GMT_earth_mask.png is 36,9 KiB. And the whole idea of the thumbnails was to reduce the sizes of the files. 2. Images without useYes, I think that we should delete those files. |
I agree with @yvonnefroehlich that using a single format can make the maintainance much easier. |
What version should I use? The old one or the new one? |
After PR #101 there are now both PNG and JPG files stored in the folder at https://github.com/GenericMappingTools/remote-datasets/tree/main/docs/_static for the
GMT_earth_age
and theGMT_earth_mask
remote dataset images. For the thumbnail images on the overview page, the JPG files are used, but for the large images on the separate documentation pages, the PNG files are used. ForGMT_earth_mask
the PNG and JPG files are not identical (please compare https://www.generic-mapping-tools.org/remote-datasets/ and https://www.generic-mapping-tools.org/remote-datasets/earth-mask.html).Maybe it makes sense to consistently use one format, i.e., the JPG format, across all remote datasets and delete the PNG files?
The text was updated successfully, but these errors were encountered: