-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include all the datasets #101
Conversation
.. grid-item-card:: IGPP Earth Free-Air Anomaly Error | ||
:link: earth-faaerrors | ||
:link-type: doc | ||
:img-bottom: /_static/GMT_earth_faaerrors_thumbnail.jpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have this image yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added what I think are all the missing images and added code to index.rst but getting some errors. Maybe you can see what is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duh. Need to add all the earth-edefl.rst etc etc. Can @Esteban82 help?
It seems you added many images in commit e0f75ad, which doesn't make sense. |
I thought the files in _static was in git so I added them there. Perhaps I dont remember how this docs work. I can remove if you can advice. |
I agree. We should page a page for every data set. |
Soy, family movie time, back in a few hours |
I guess I am leaning towards including everything, even the gebcosi. I know we cannot see much different on thumbnails for Earth relief, gebco, synbath, but gebcosi at least differs over Antarctica, no? |
We already have |
We also have a figure with the mix of earth day/night images. |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 30.7%, saving 1.07 MB.
20 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
Sorry, best to approve this one and then fix a smaller set of issues. |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 2.1%, saving 8.85 KB.
48 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
Need to show all of them. Kept mdt out of the check script which specifically try 5 and 6 minutes.