Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all the datasets #101

Merged
merged 7 commits into from
Nov 5, 2023
Merged

Include all the datasets #101

merged 7 commits into from
Nov 5, 2023

Conversation

PaulWessel
Copy link
Member

Need to show all of them. Kept mdt out of the check script which specifically try 5 and 6 minutes.

@PaulWessel PaulWessel added the documentation Improvements or additions to documentation label Nov 3, 2023
@PaulWessel PaulWessel self-assigned this Nov 3, 2023
docs/index.rst Show resolved Hide resolved
.. grid-item-card:: IGPP Earth Free-Air Anomaly Error
:link: earth-faaerrors
:link-type: doc
:img-bottom: /_static/GMT_earth_faaerrors_thumbnail.jpg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have this image yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added what I think are all the missing images and added code to index.rst but getting some errors. Maybe you can see what is missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duh. Need to add all the earth-edefl.rst etc etc. Can @Esteban82 help?

@seisman
Copy link
Member

seisman commented Nov 3, 2023

It seems you added many images in commit e0f75ad, which doesn't make sense.

@PaulWessel
Copy link
Member Author

It seems you added many images in commit e0f75ad, which doesn't make sense.

I thought the files in _static was in git so I added them there. Perhaps I dont remember how this docs work. I can remove if you can advice.

@Esteban82
Copy link
Member

Need to show all of them.

I agree. We should page a page for every data set.
But I don't know if we should show all of them on the main page. For example the gebco and gebcosi. (This would mean that we don't have to make thumbnail for all the images).

@PaulWessel
Copy link
Member Author

Soy, family movie time, back in a few hours

@PaulWessel
Copy link
Member Author

I guess I am leaning towards including everything, even the gebcosi. I know we cannot see much different on thumbnails for Earth relief, gebco, synbath, but gebcosi at least differs over Antarctica, no?
I forgot to run the candidate server update so did that earlier today and the scripts now can make all the plots I think. Might still need work on the makefile (cannot have make docs if there is a directory named docs, so need to change target name, e.g., make html (which is what the docs/Makefile uses).

@seisman
Copy link
Member

seisman commented Nov 4, 2023

It seems you added many images in commit e0f75ad, which doesn't make sense.

I thought the files in _static was in git so I added them there. Perhaps I dont remember how this docs work. I can remove if you can advice.

We already have docs/_static/GMT_earth_age.png, but in commit e0f75ad, you added the new GMT_earth_age.jpg (PNG vs JPG).

@Esteban82
Copy link
Member

We also have a figure with the mix of earth day/night images.

Copy link
Contributor

github-actions bot commented Nov 5, 2023

Images automagically compressed by Calibre's image-actions

Compression reduced images by 30.7%, saving 1.07 MB.

Filename Before After Improvement Visual comparison
docs/_static/GMT_earth_age_thumbnail.jpg 36.70 KB 24.58 KB -33.0% View diff
docs/_static/GMT_earth_age.jpg 106.49 KB 71.79 KB -32.6% View diff
docs/_static/GMT_earth_day_thumbnail.jpg 26.68 KB 19.07 KB -28.5% View diff
docs/_static/GMT_earth_day.jpg 80.68 KB 58.00 KB -28.1% View diff
docs/_static/GMT_earth_edefl_thumbnail.jpg 54.76 KB 41.30 KB -24.6% View diff
docs/_static/GMT_earth_edefl.jpg 199.56 KB 151.00 KB -24.3% View diff
docs/_static/GMT_earth_faa_thumbnail.jpg 69.72 KB 46.50 KB -33.3% View diff
docs/_static/GMT_earth_faa.jpg 254.36 KB 171.77 KB -32.5% View diff
docs/_static/GMT_earth_faaerror_thumbnail.jpg 57.58 KB 35.40 KB -38.5% View diff
docs/_static/GMT_earth_faaerror.jpg 202.51 KB 122.34 KB -39.6% View diff
docs/_static/GMT_earth_gebco_thumbnail.jpg 64.97 KB 46.33 KB -28.7% View diff
docs/_static/GMT_earth_gebco.jpg 227.41 KB 164.21 KB -27.8% View diff
docs/_static/GMT_earth_geoid_thumbnail.jpg 52.53 KB 35.72 KB -32.0% View diff
docs/_static/GMT_earth_geoid.jpg 171.54 KB 116.70 KB -32.0% View diff
docs/_static/GMT_earth_mag_thumbnail.jpg 53.86 KB 35.72 KB -33.7% View diff
docs/_static/GMT_earth_mag.jpg 203.85 KB 136.86 KB -32.9% View diff
docs/_static/GMT_earth_mask_thumbnail.jpg 27.73 KB 18.96 KB -31.6% View diff
docs/_static/GMT_earth_mask.jpg 77.52 KB 53.66 KB -30.8% View diff
docs/_static/GMT_earth_mdt_thumbnail.jpg 37.71 KB 25.77 KB -31.7% View diff
docs/_static/GMT_earth_mdt.jpg 111.67 KB 77.14 KB -30.9% View diff
docs/_static/GMT_earth_mss_thumbnail.jpg 43.65 KB 29.05 KB -33.5% View diff
docs/_static/GMT_earth_mss.jpg 138.72 KB 92.14 KB -33.6% View diff
docs/_static/GMT_earth_ndefl_thumbnail.jpg 54.39 KB 41.08 KB -24.5% View diff
docs/_static/GMT_earth_ndefl.jpg 196.09 KB 148.53 KB -24.3% View diff
docs/_static/GMT_earth_night_thumbnail.jpg 13.93 KB 9.74 KB -30.1% View diff
docs/_static/GMT_earth_night.jpg 43.90 KB 31.06 KB -29.2% View diff
docs/_static/GMT_earth_relief_thumbnail.jpg 64.87 KB 46.25 KB -28.7% View diff
docs/_static/GMT_earth_relief.jpg 227.39 KB 164.03 KB -27.9% View diff
docs/_static/GMT_earth_vgg_thumbnail.jpg 50.11 KB 37.44 KB -25.3% View diff
docs/_static/GMT_earth_vgg.jpg 187.31 KB 140.59 KB -24.9% View diff
docs/_static/GMT_earth_wdmam_thumbnail.jpg 87.01 KB 56.49 KB -35.1% View diff
docs/_static/GMT_earth_wdmam.jpg 331.24 KB 215.44 KB -35.0% View diff

20 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@PaulWessel
Copy link
Member Author

Sorry, best to approve this one and then fix a smaller set of issues.

Copy link
Contributor

github-actions bot commented Nov 5, 2023

Images automagically compressed by Calibre's image-actions

Compression reduced images by 2.1%, saving 8.85 KB.

Filename Before After Improvement Visual comparison
docs/_static/GMT_earth_faaerror_thumbnail.jpg 35.40 KB 34.84 KB -1.6% View diff
docs/_static/GMT_earth_faaerror.jpg 122.34 KB 120.04 KB -1.9% View diff
docs/_static/GMT_earth_wdmam_thumbnail.jpg 56.49 KB 55.21 KB -2.3% View diff
docs/_static/GMT_earth_wdmam.jpg 215.44 KB 210.72 KB -2.2% View diff

48 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@PaulWessel PaulWessel merged commit 6d922d1 into main Nov 5, 2023
2 checks passed
@PaulWessel PaulWessel deleted the update-fig-scripts branch November 5, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants