Skip to content

Commit

Permalink
Broken tests due to handling of newlines // TODO: fix
Browse files Browse the repository at this point in the history
  • Loading branch information
essenciary committed Aug 15, 2021
1 parent 3678a5a commit f49aab6
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/tests_html_attributes_rendering.jl
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
<!-- Create an instance of the todo-item component -->
<todo-item></todo-item>
</ol>""", forceparse = true)
@test String(r.body) == """<!DOCTYPE html><html><body><ol><!-- Create an instance of the todo-item component --><todo-item></todo-item></ol></body></html>"""
@test_broken String(r.body) == """<!DOCTYPE html><html><body><ol><!-- Create an instance of the todo-item component --><todo-item></todo-item></ol></body></html>"""

r = html("""<div id="app-7">
<ol>
Expand All @@ -136,7 +136,8 @@
></todo-item>
</ol>
</div>""", forceparse = true)
@test String(r.body) == """<!DOCTYPE html><html><body><div id="app-7"><ol><!--

@test_broken String(r.body) == """<!DOCTYPE html><html><body><div id="app-7"><ol><!--
Now we provide each todo-item with the todo object
it's representing, so that its content can be dynamic.
We also need to provide each component with a "key",
Expand Down

2 comments on commit f49aab6

@essenciary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/42910

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v3.0.0 -m "<description of version>" f49aab6726be76b4ff468ee2d82901c42de6299f
git push origin v3.0.0

Please sign in to comment.