core_theme now only affects whether standard css is loaded #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on js). This is also a bugfix (before, core_theme = false resulted in an error)
|
Thank you @jochenkrattenmacher I had just fixed the same issue myself when I came across the same problem. But I had not seen the requirements in deps_routes, which luckily you found. So your PR ends up in fixing the two remaining lines... Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core_theme now only affects whether standard css is loaded (no more effect on js). This is also a bugfix (before, supplying page() with core_theme = false resulted in a julia compilation error). This PR is just a suggestion, please let me know if working like this doesn't make sense (I am new)
#115
#156