Merge pull request from GHSA-wwgf-3xp7-cxj4

Remove call to Topic::broadcast() if the dispatch method fails
GeniusesOfSymfony · Jul 6, 2020 · 2d8dfd9 · 2d8dfd9
2 parents c357e3a + 8048314
commit 2d8dfd9
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/Server/App/Dispatcher/TopicDispatcher.php b/Server/App/Dispatcher/TopicDispatcher.php
@@ -113,12 +113,7 @@ public function onUnSubscribe(ConnectionInterface $conn, Topic $topic, WampReque
      */
     public function onPublish(ConnectionInterface $conn, Topic $topic, WampRequest $request, $event, array $exclude, array $eligible)
     {
-        if (!$this->dispatch(self::PUBLISH, $conn, $topic, $request, $event, $exclude, $eligible)) {
-            //default behaviour is to broadcast to all.
-            $topic->broadcast($event);
-
-            return;
-        }
+        $this->dispatch(self::PUBLISH, $conn, $topic, $request, $event, $exclude, $eligible);
     }
 
     /**