Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the benchmarking script #172

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Oct 5, 2022

  • Fix a bug localizing an MSPC version on Mac where the default temp dir dotnet uses may not be accessible by the user running the application. Using sudo may not also fix it. Hence, switch to using the current execution dir instead of the system/user temp dir.
  • Improve on calling parser and handling exceptions; with this change, errors are handled by the provided delegate rather than the default delegate of CLI (which also prints the stack trace that is not useful to the end-user);
  • Check if the given data directory exists before proceeding.

…ould be localized.

# Temp seems not to be portable. It fails on mac with access-related issue and running with sudo does not fix it either.
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #172 (d384b7a) into dev (0809a20) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #172   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files          43       43           
  Lines        2091     2091           
=======================================
  Hits         2037     2037           
  Misses         10       10           
  Partials       44       44           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VJalili VJalili merged commit 8471735 into Genometric:dev Oct 5, 2022
@VJalili VJalili deleted the val_scripts branch October 5, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant