Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug reporting incorrect number of consensus peaks on the terminal #181

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Nov 15, 2022

This PR fixes a bug where MSPC is not reporting a correct number of the identified consensus peaks on the terminal. The issue is related to the recently added stranded analysis (#176), where MSPC wrote in the terminal the number of strands instead of the peak count for consensus peaks.

This PR adds a unit test to reproduce the issue and fixes the bug.

Thanks to @MeriemBahda for reporting this bug!

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #181 (502262f) into dev (1fb64b7) will not change coverage.
The diff coverage is n/a.

❗ Current head 502262f differs from pull request most recent head 0ed52a1. Consider uploading reports for the commit 0ed52a1 to get more accurate results

@@           Coverage Diff           @@
##              dev     #181   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files          43       43           
  Lines        2178     2178           
=======================================
  Hits         2124     2124           
  Misses         10       10           
  Partials       44       44           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VJalili VJalili merged commit b69d149 into Genometric:dev Nov 15, 2022
@VJalili VJalili deleted the consensus_peaks branch November 15, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant