Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FASTA sequence download #106

Merged
merged 7 commits into from
Oct 11, 2022
Merged

feat: add FASTA sequence download #106

merged 7 commits into from
Oct 11, 2022

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Oct 10, 2022

close #102

uta_tools/main.py Outdated Show resolved Hide resolved
@jsstevenson jsstevenson marked this pull request as ready for review October 10, 2022 12:17
korikuzma
korikuzma previously approved these changes Oct 10, 2022
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

uta_tools/main.py Outdated Show resolved Hide resolved
tests/unit/test_uta_tools.py Show resolved Hide resolved
korikuzma
korikuzma previously approved these changes Oct 11, 2022
uta_tools/uta_tools.py Outdated Show resolved Hide resolved
aliases = self._get_fasta_aliases(sequence_id, ["refseq", "ga4gh"])
header = f">emb|ensembl:{sequence_id}|{'|'.join(aliases)}"
else:
aliases = self._get_fasta_aliases(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wanted to add a test for this, we could use the seguid

jsstevenson and others added 3 commits October 11, 2022 08:27
Co-authored-by: Kori Kuzma <42851808+korikuzma@users.noreply.github.com>
@jsstevenson
Copy link
Member Author

alright! maybe finally done?

Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jsstevenson jsstevenson merged commit a59c823 into staging Oct 11, 2022
@jsstevenson jsstevenson deleted the issue-102 branch October 11, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants