Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use FastApi APIRouter #127

Merged
merged 1 commit into from
Mar 2, 2023
Merged

refactor: use FastApi APIRouter #127

merged 1 commit into from
Mar 2, 2023

Conversation

korikuzma
Copy link
Member

Close #125

This doesn't fix the issue we originally wanted (reduce copy/paste for our other applications), but it does clean it up! I can make a new issue to see if there's a way to reuse the routers

@korikuzma korikuzma added enhancement New feature or request priority:low Low priority labels Mar 2, 2023
@korikuzma korikuzma self-assigned this Mar 2, 2023
jsstevenson
jsstevenson approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this doesn't alter any functionality, then I don't think it should have the "feat" type ("refactor"?). otherwise 👍

@korikuzma korikuzma changed the title feat: use FastApi APIRouter refactor: use FastApi APIRouter Mar 2, 2023
@korikuzma
Copy link
Member Author

if this doesn't alter any functionality, then I don't think it should have the "feat" type ("refactor"?). otherwise 👍

Oh ya, sorry brain is 💩 at EOD

@korikuzma korikuzma added technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced and removed enhancement New feature or request technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Mar 2, 2023
@korikuzma korikuzma merged commit 8e3745c into staging Mar 2, 2023
@korikuzma korikuzma deleted the issue-125 branch March 2, 2023 20:37
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced priority:low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@korikuzma @jsstevenson