Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: allow static file paths to be set via env var #133

Merged
merged 1 commit into from
Mar 22, 2023
Merged

refactor: allow static file paths to be set via env var #133

merged 1 commit into from
Mar 22, 2023

Conversation

korikuzma
Copy link
Member

Close #131

Notes:

  • SEQREPO_DATA_PATH, TRANSCRIPT_MAPPINGS_PATH, MANE_SUMMARY_PATH, and LRG_REFSEQGENE_PATH paths can now be set using env vars
  • Updates type hints / docstrings for these to be Path rather than string

@korikuzma
refactor: allow static file paths to be set via env var
60392fd 
- SEQREPO_DATA_PATH, TRANSCRIPT_MAPPINGS_PATH, MANE_SUMMARY_PATH, and
  LRG_REFSEQGENE_PATH paths can now be set using env vars
- Updates type hints / docstrings for these to be Path rather than
  string
@korikuzma korikuzma added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Mar 20, 2023
@korikuzma korikuzma self-assigned this Mar 20, 2023
jsstevenson
jsstevenson approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@korikuzma korikuzma merged commit b375a20 into staging Mar 22, 2023
@korikuzma korikuzma deleted the issue-131 branch March 22, 2023 17:22
@github-actions github-actions bot mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@korikuzma @jsstevenson