Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: SeqRepoAccess extends vrs-python's SeqRepoDataProxy class #138

Merged
merged 1 commit into from
Mar 31, 2023
Merged

refactor!: SeqRepoAccess extends vrs-python's SeqRepoDataProxy class #138

merged 1 commit into from
Mar 31, 2023

Conversation

korikuzma
Copy link
Member

Close #96

Notes:

  • Will update dependencies after this gene-normalizer PR gets merged. I was having trouble using pipenv to update dependencies and am hoping this will resolve the errors.
  • SeqRepoAccess translate_identifier method: parameter changed from target_namespace --> target_namespaces
  • SeqRepoAccess aliases method: renamed to translate_alias

@korikuzma
refactor!: SeqRepoAccess extends vrs-python's SeqRepoDataProxy class
11f23c5 
- SeqRepoAccess translate_identifier method: parameter changed from
  target_namespace --> target_namespaces
- SeqRepoAccess aliases method: renamed to translate_alias
@korikuzma korikuzma added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Mar 31, 2023
@korikuzma korikuzma self-assigned this Mar 31, 2023
@korikuzma korikuzma merged commit ab8a276 into staging Mar 31, 2023
@korikuzma korikuzma deleted the issue-96 branch March 31, 2023 15:17
@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@korikuzma @jsstevenson