refactor: update to lastest version of gene-normalizer #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QueryHandler now accepts Database instance in the latest version
korikuzma
added
priority:high
jsstevenson
requested changes
Apr 18, 2023
@jsstevenson I'm not sure what the notation is for allowing multiple minor versions, while also excluding some older versions. I'm looking at this. |
|
@korikuzma yeah that's a good point. Pinning 0.1.29+ at least solves half of the problem (sort of joking, but sort of serious) |
@jsstevenson we could do something like this |
|
@korikuzma Fine w/ me |
Closed
jsstevenson
approved these changes
Apr 19, 2023
Closed
korikuzma
added a commit
that referenced
this pull request
Apr 19, 2023
* gene-normalizer versions allowed: >= 0.1.34 OR >= 0.2.9 * QueryHandler now accepts Database instance in the latest version * CoolSeqTool now has a gene_query_handler instance var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #145
Needed for work in this variation normalizer issue