Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use ResidueMode for residue_mode type #199

Merged
merged 12 commits into from
Oct 12, 2023
Merged

refactor: use ResidueMode for residue_mode type #199

merged 12 commits into from
Oct 12, 2023

Conversation

korikuzma
Copy link
Member

Close #185

Notes:

  • Inconsistent with using ResidueMode vs str

@korikuzma korikuzma added priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Oct 8, 2023
@korikuzma korikuzma self-assigned this Oct 8, 2023
jsstevenson
jsstevenson previously approved these changes Oct 9, 2023
View reviewed changes
Base automatically changed from issue-192 to main October 12, 2023 16:13
@korikuzma korikuzma dismissed jsstevenson’s stale review October 12, 2023 16:13

The base branch was changed.

jsstevenson
jsstevenson approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@korikuzma korikuzma merged commit 87a5579 into main Oct 12, 2023
2 checks passed
@korikuzma korikuzma deleted the issue-185 branch October 12, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use an enum for residue_mode type annotations
2 participants
@korikuzma @jsstevenson