feat!: include cdna and protein represenation when starting from genomic layer #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Inconsistent with using ResidueMode vs str
- Some places we were not using it when we should have been
* Now returns MANE Select and then MANE Plus Clinical
korikuzma
added
enhancement
jsstevenson
approved these changes
Dec 11, 2023
korikuzma
added a commit
that referenced
this pull request
Jan 9, 2024
…mic layer (#228) * Return pydantic models rather than dictionaries for `ManeTranscript` methods: `get_mane_transcript`, `_get_c_data`, `_get_mane_p`, `get_longest_compatible_transcript`, `g_to_mane_c` * Renamed `grch38_to_mane_p` -> `grch38_to_mane_c_p` since it now includes cdna representation as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #151 . This work is needed for VarCat.
Notes:
ManeTranscriptmethods:get_mane_transcript,_get_c_data,_get_mane_p,get_longest_compatible_transcript,g_to_mane_cDataRepresentation. It felt weird namingProteinRepresentationand havingCdnaRepresentationinherit from it.grch38_to_mane_p->grch38_to_mane_c_psince it now includes cdna representation as well