fix!: return inter-residue positions instead of zero-based positions #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 589a6b1.
korikuzma
changed the title
jsstevenson
reviewed
Dec 26, 2023
Comment on lines
+53
to
+58
| | | C | | T | | G | | | ||
| ZERO | | 0 | | 1 | | 2 | | | ||
| RESIDUE | | 1 | | 2 | | 3 | | | ||
| INTER_RESIDUE | 0 | | 1 | | 2 | | 3 | | ||
| """ | ||
|
|
jsstevenson
approved these changes
Dec 26, 2023
This was
linked to
issues
Dec 26, 2023
korikuzma
added a commit
that referenced
this pull request
Dec 27, 2023
…235) * Fix TypeError in `SeqRepoAccess.get_reference_sequence()` when `start` is not provided * Requires both start and end positions to be provided (`get_mane_transcript` and `get_inter_residue_pos`)
korikuzma
added a commit
that referenced
this pull request
Jan 9, 2024
…235) * Fix TypeError in `SeqRepoAccess.get_reference_sequence()` when `start` is not provided * Requires both start and end positions to be provided (`get_mane_transcript` and `get_inter_residue_pos`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #176 and #225
Notes:
ExonGenomicCoordsMapperand associated tests. Don't look too closely at this. I'll be working on this later. I'm going to ask @jarbesfeld to help ensure that tests are accurate.test_get_longest_compatible_transcript. I will make a separate issue for these.SeqRepoAccess.get_reference_sequence()whenstartis not providedget_mane_transcriptandget_inter_residue_pos)