chore: remove todo's in tests #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* UTADatabase -> UtaDatabase * MANETranscript -> ManeTranscript * MANETranscriptMappings -> ManeTranscriptMappings
korikuzma
added
priority:low
jsstevenson
approved these changes
Jan 2, 2024
This reverts commit 31c8c5b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #237
I checked and believe that the output is expected for the provided input positions. If we provide 603 and 1808, we would get what is seen in CA123643 (which is what I thought was wrong with the issue). Similar to what was happening in #172, where it all depends on what initial positions are provided.