Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ChEMBL and Mondo #1

Merged
merged 14 commits into from
Oct 19, 2023
Merged

feat: Add ChEMBL and Mondo #1

merged 14 commits into from
Oct 19, 2023

Conversation

jsstevenson
Copy link
Member

These are our two current problem children.

  • ChEMBL: downloads via HTTP. I think FTP is probably faster, but I've been ~unable to maintain an FTP connection with the EMBL FTP server at the hospital, so I think it's easier to just go with HTTP, particularly since they don't do too many updates.
  • Mondo: Includes some extra methods to support trying previous versions. The most recent Mondo release is unparseable by our OWL reader, and while I think they're going to make a change that resolves this, I don't think they view it as an urgent or critical fix (the problem is really with owlready2, not with their data output).

There's a little bit of repeated code here. I think it'd be better to hold off on consolidating methods until we've seen what it looks like to implement this for every source that we're interested in.

@jsstevenson jsstevenson added enhancement New feature or request priority:medium Medium priority labels Oct 16, 2023
@jsstevenson jsstevenson marked this pull request as ready for review October 16, 2023 17:31
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jsstevenson jsstevenson merged commit 3cf0cf2 into main Oct 19, 2023
10 checks passed
@jsstevenson jsstevenson deleted the basics branch October 19, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants