feat: add therapy-normalizer data sources #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsstevenson
changed the title
jsstevenson
commented
Nov 3, 2023
Comment on lines
+67
to
+69
| def get_latest( | ||
| self, from_local: bool = False, force_refresh: bool = False | ||
| ) -> Tuple[GtoPLigandPaths, str]: |
There was a problem hiding this comment.
hemonc and gtop both acquire multiple files. With HemOnc, it's basically a bundle (each one is meaningless without the others) but with GtoP, it's just a selection of useful files (and in fact, DGIdb uses a different selection of GtoP files). I thought about a few different ways to handle this (including making a separate class for each file) and all of them were sort of awkward. I think returning a namedtuple of paths like this is the easiest way to handle it for data consumers.
jsstevenson
requested review from
korikuzma
and removed request for
korikuzma
|
TODO for next week/week after: chembl download is being weird |
|
also TODO document rxnorm api key requirement |
korikuzma
requested changes
Nov 15, 2023
korikuzma
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3