Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Gene Normalizer sources #18

Merged
merged 2 commits into from
Nov 28, 2023
Merged

feat: add Gene Normalizer sources #18

merged 2 commits into from
Nov 28, 2023

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Nov 27, 2023

  • I split up the NCBI stuff because I think that while gene info/history are sort of tightly coupled (ideally they should be the same version), they're qualitatively different, and not dependent on, the genome annotation file.
  • We get all this stuff via FTP. It's a lot harder to mock (I didn't bother here -- we weren't previously mocking it in Gene Normalizer tests) and also the EBI FTP server seems to just block login attempts sometimes... might be worth it to just switch to HTTP.

@jsstevenson jsstevenson marked this pull request as ready for review November 28, 2023 18:18
@jsstevenson jsstevenson merged commit d5f0480 into main Nov 28, 2023
10 checks passed
@jsstevenson jsstevenson deleted the gene-sources branch November 28, 2023 18:25
@jsstevenson jsstevenson mentioned this pull request Nov 28, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants