Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference_genome parameter from GenomicsDB constructor and refactor to move plink support to its own .h/.cc files #214

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

nalinigans
Copy link
Member

@nalinigans nalinigans commented Jul 12, 2022

  1. Reference Genome is not required for normal queries and is moved out of the constructor into methods - generate-vcf when broad-type gvcf files have to be created from GenomicsDB. Also, support for vcf header templates to be specified to generate-vcf has been added.
  2. The plink support exposes a lot of internal classes that are not part of the release and breaks building Python/R bindings to GenomicsDB that are external to the project. Moved the support out of genomicsdb into its own header and implementation files - see genomicsdb_plink.h and genomicsdb_plink.cc.
  3. Did some refactoring and cleanup of the code, but internal dependencies from plink need to be removed to allow for Python/R bindings. Also, the c unit test test_bgen.cc may need to be rewritten to use goodies from Catch2 and TempDir. Will probably have to give some thought to refactoring the bgen writer as this was mentioned in the gatk meeting. Will file Issues for these later.

… reference_genome parameter from GenomicsDB constructor
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #214 (977b373) into develop (5802023) will decrease coverage by 0.00%.
The diff coverage is 88.95%.

@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
- Coverage    76.73%   76.72%   -0.01%     
===========================================
  Files          166      168       +2     
  Lines        25036    25027       -9     
  Branches       441      440       -1     
===========================================
- Hits         19212    19203       -9     
  Misses        5599     5599              
  Partials       225      225              
Impacted Files Coverage Δ
tools/src/gt_mpi_gather.cc 69.65% <0.00%> (+0.44%) ⬆️
...nomicsdb/spark/api/GenomicsDBQueryInputFormat.java 69.04% <50.00%> (ø)
...in/java/org/genomicsdb/reader/GenomicsDBQuery.java 79.68% <75.00%> (ø)
src/main/cpp/src/api/genomicsdb_plink.cc 87.40% <87.40%> (ø)
src/main/cpp/include/api/genomicsdb_plink.h 93.25% <93.25%> (ø)
src/test/cpp/src/test_bgen.cc 80.51% <95.45%> (-6.99%) ⬇️
src/main/cpp/include/api/genomicsdb.h 90.26% <100.00%> (-1.97%) ⬇️
...c/main/cpp/include/config/genomicsdb_config_base.h 96.72% <100.00%> (+0.05%) ⬆️
src/main/cpp/src/api/genomicsdb.cc 93.50% <100.00%> (+3.76%) ⬆️
src/main/cpp/src/api/genomicsdb_field.cc 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5802023...977b373. Read the comment docs.

Copy link
Contributor

@mlathara mlathara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants