Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base docker image #273

Merged
merged 2 commits into from Mar 11, 2023
Merged

Update base docker image #273

merged 2 commits into from Mar 11, 2023

Conversation

mlathara
Copy link
Contributor

Update base image to resolve some CVEs. I had it pinned to a specific docker base image but...I think it is best to just take the latest image for the base OS.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #273 (83a5fa9) into develop (d3ed40c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #273   +/-   ##
==========================================
  Coverage      75.35%   75.35%           
  Complexity         1        1           
==========================================
  Files            149      149           
  Lines          20493    20493           
  Branches         440      440           
==========================================
  Hits           15443    15443           
  Misses          4830     4830           
  Partials         220      220           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nalinigans nalinigans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just for my understanding, would os=ubuntu:20.04 work instead of os=ubuntu:focal. That is would it also pull in the latest 20.04 image?

@mlathara
Copy link
Contributor Author

Yup - looks like that is also an available tag. TIL! https://hub.docker.com/_/ubuntu/tags?page=1&name=20.04

@mlathara mlathara merged commit f902910 into develop Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants