Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Support #10

Closed
Zero3K opened this issue Apr 9, 2017 · 6 comments
Closed

Notification Support #10

Zero3K opened this issue Apr 9, 2017 · 6 comments

Comments

@Zero3K
Copy link

Zero3K commented Apr 9, 2017

It would be nice if the app had a notification that provided some details of the connection.

@rom1v
Copy link
Collaborator

rom1v commented Apr 10, 2017

Android already display the "key logo" in the status bar, from where it is possible to disconnect. On some Android ROM, this is even a simple notification instead. Providing an additional notification to know the VPN state would be redundant IMO.

However, we planned to implement a notification in the case where the VPN is enabled but the connection to the relay server is lost (typically when the device has been unplugged), so that the user is warned of the problem and may disconnect the VPN easily.

@Zero3K
Copy link
Author

Zero3K commented Apr 12, 2017

That makes sense to me. Maybe it could even disconnect the VPN automatically when the USB cable is unplugged.

@rom1v
Copy link
Collaborator

rom1v commented Apr 12, 2017

Maybe it could even disconnect the VPN automatically when the USB cable is unplugged.

It would be more convenient, but it may lead to security issues in some cases IMO.

We don't detect "USB cable is unplugged", but rather "TCP connection is broken between the client and the relay server". If someone uses gnirehtet to force sensitive traffic to be forwarded to a local network so that it is never sent to "the internet" (using 4G connection for instance), then they don't want the VPN to be automatically turned off only because there is a problem on the TCP connection.

More generally, a VPN should not be automatically stopped.

@Zero3K
Copy link
Author

Zero3K commented Apr 18, 2017

Thanks for adding the notification you were writing about. I am closing this issue now since it has been taken care of.

@Zero3K Zero3K closed this as completed Apr 18, 2017
@rom1v
Copy link
Collaborator

rom1v commented Apr 18, 2017

;-)

It's still in the dev branch (commit a1bb3c6), it will be in the next release.

notification

@Zero3K
Copy link
Author

Zero3K commented Apr 18, 2017

That's the branch I am compiling from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants