New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: separate approve and perform buttons #257
feat: separate approve and perform buttons #257
Conversation
Thanks for taking this one on quickly @tnrdd! Just a couple issues/changes:
|
This is probably a regression from when I was adjusting the signers to prevent a bunch of RPC calls. Let's create a new ticket and address separately. |
Created a separate ticket for the last issue here: #258 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bb915e7
to
00adbb0
Compare
Signer changes are working as expected with the latest @codynhat, this is ready for you again. |
Description
Separate the approve and perform buttons to two different components.
Issue
fixes #252
Checklist:
develop
branchdevelop
branchAlert Reviewers
@codynhat @gravenp