Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoCoq broken with Coq 8.9 (master) #12

Closed
Zimmi48 opened this issue Jun 7, 2018 · 3 comments
Closed

GeoCoq broken with Coq 8.9 (master) #12

Zimmi48 opened this issue Jun 7, 2018 · 3 comments

Comments

@Zimmi48
Copy link
Contributor

Zimmi48 commented Jun 7, 2018

Lemma colH_dec : forall A B C, ColH A B C \/ ~ColH A B C.
Hint Resolve colH_trivial121 colH_trivial122 colH_trivial112 colH_trivial111 colH_permut_231 colH_permut_312 colH_permut_321
colH_permut_213 colH_permut_132 colH_permut_231 : colH.

This lemma is only proved at the very end of the file. In Coq 8.9, nested lemmas are disabled unless you turn option Nested Proofs Allowed on. So you should either add Set Nested Proofs Allowed at the beginning on this file, or move this lemma's statement to the bottom, right before its proof.

@Zimmi48
Copy link
Contributor Author

Zimmi48 commented Jun 7, 2018

cc @Boutry

@Zimmi48
Copy link
Contributor Author

Zimmi48 commented Jun 7, 2018

BTW this big commit also introduced a dependency on math-comp which is not indicated in the changelog.

ejgallego added a commit to ejgallego/coq that referenced this issue Jun 7, 2018
We build a bit of math-comp so it works, also patch in the old-style
until the upstream issue is fixed.
ejgallego added a commit to ejgallego/coq that referenced this issue Jun 7, 2018
We build a bit of math-comp so it works, also patch in the old-style
until the upstream issue is fixed.
ejgallego added a commit to ejgallego/coq that referenced this issue Jun 8, 2018
We build a bit of math-comp so it works, also patch in the old-style
until the upstream issue is fixed.
ejgallego added a commit to ejgallego/coq that referenced this issue Jun 8, 2018
We build a bit of math-comp so it works, also patch in the old-style
until the upstream issue is fixed.
@jnarboux
Copy link
Member

jnarboux commented Jun 9, 2018

Thank you for reporting, it was a typo, the nested lemma has been deleted. I added a word about the math-comp dependency in the Changelog.

@jnarboux jnarboux closed this as completed Jun 9, 2018
ejgallego added a commit to ejgallego/coq that referenced this issue Jun 10, 2018
We build a bit of math-comp so it works, also patch in the old-style
until the upstream issue is fixed.
SkySkimmer added a commit to SkySkimmer/coq that referenced this issue Jun 11, 2018
Zimmi48 added a commit to Zimmi48/coq that referenced this issue Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants