Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

box plot statistics misaligned and in different units #1687

Closed
lanselin opened this issue Aug 3, 2018 · 7 comments
Closed

box plot statistics misaligned and in different units #1687

lanselin opened this issue Aug 3, 2018 · 7 comments

Comments

@lanselin
Copy link
Collaborator

lanselin commented Aug 3, 2018

Something has changed in the drawing of a box plot. Not sure when it happened, but it happened after March 2018, when the screen shots for the last version of the workbook were made. In that version, the descriptive statistics are centered under the plot, currently they seem to be right aligned and look awkward. Also, the default for the units units on the axes seems to have changed. The old way was better. This should be turned back to the original logic. See screen shots with original (with figure numbers from the work book) and current.

screen shot 2018-08-03 at 3 23 29 pm

screen shot 2018-08-03 at 3 25 00 pm

screen shot 2018-08-03 at 3 25 42 pm

screen shot 2018-08-03 at 3 25 27 pm

@lixun910
Copy link
Member

lixun910 commented Aug 3, 2018

that's caused by the fix: a8c219f
The international version GeoDa e.g. Chinese version has translated labels (min, max ...) not align well with the numbers. Will fix it.

@lixun910
Copy link
Member

lixun910 commented Aug 4, 2018

form luc: The default should be that an integer is displayed as an integer.
But there are use cases where one might want to show a higher precision, for example,
when the value is a $ amount with two decimals. So, the option to change the display
precision should not be constrained.

@Ashitacarl
Copy link

GeoDa 1.12.1.179 (macOS Mojave, 10.14.1).

The box plots align well now, with preferred precision.

1687

@jkoschinsky
Copy link
Collaborator

still need to be fixed:
old version didn't have .00 on y-axis but current one does

@lixun910
Copy link
Member

There is an option in right click menu: View->Set Display Precision on Axes. By default, it is set to 2, so that's why it has .00 Now, this fix will check if the number is an integer or not. If the number on an axis is an integer, then there will be no .00 appended; if the number is a floating point number, then the "Set Display Precision on Axes" will be applied. See the screenshot:

Both use Guerry: scatterplot (distanc, infants -- no meaning, just bringing distanc as a real type).
Right plot is set to "View Standardized Data". You will see on the left plot, "Set Display Precision on Axes" won't work, since all numbers on both axes are integers; but on the right plot, "Set Display Precision on Axes" will work:

screen shot 2018-12-17 at 4 45 17 pm

@lixun910
Copy link
Member

@jkoschinsky if apply this fix, then the plot will be different than the plot in current lab. see below:
Let mw know if you want this fix, or keep to have .00 on y-axis.

apply this fix (no .00 on y-axis):
image

screen shot 2018-12-17 at 5 17 15 pm

in current lab screenshot:
image

image

@jkoschinsky
Copy link
Collaborator

@lixun910 I see what you're saying -- let's keep it the same as in the current lab, thx

@jkoschinsky jkoschinsky removed the bug label Dec 19, 2018
lixun910 added a commit to lixun910/geoda that referenced this issue Dec 19, 2018
revert to still use .00 on x/y axes in plots (e.g. box plot, scatter plot etc.) so to match the screenshot in lab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants