Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skater spanning tree gwt format incorrect #1764

Closed
lanselin opened this issue Nov 28, 2018 · 6 comments
Closed

skater spanning tree gwt format incorrect #1764

lanselin opened this issue Nov 28, 2018 · 6 comments

Comments

@lanselin
Copy link
Collaborator

The gwt weights file saved by "save spanning tree" in skater does not have the correct format. Apart from it not having an id variable in the header line (see #1763), it also is not symmetric. The link between any i and j is only recorded once, the symmetric link between j and i is not included.

This leads to strange results, such as the number of neighbors given as 0 whereas there always is at least one neighbor (by definition). For example, observation 5 gives 0 neighbors (last column)

screen shot 2018-11-27 at 7 36 26 pm

but in fact it has one neighbor

screen shot 2018-11-27 at 7 37 01 pm

in the gwt file, the connection between 4 and 5 is included, but the connection between 5 and 4 is not, hence the latter shows up as having no neighbors.

screen shot 2018-11-27 at 7 37 46 pm

lixun910 added a commit to lixun910/geoda that referenced this issue Dec 4, 2018
skater spanning tree weights properties incorrect GeoDaCenter#1765
skater spanning tree gwt format incorrect GeoDaCenter#1764
no id variable for gwt skater spanning tree GeoDaCenter#1763
@lixun910 lixun910 mentioned this issue Dec 7, 2018
@Ashitacarl
Copy link

GeoDa 1.12.1.181 (macOS Mojave, 10.14.1). Dec. 10 build.

Fix verified.
The skater gwt weight is now symmetric.

1764

@lixun910 By clicking "Save Spanning Tree", GeoDa only saves "CL" (cluster) but not the number of neighbors. Is it an extra step to get the number of neighbors?

@lixun910
Copy link
Member

@Ashitacarl I am not sure if I understand your question:
By clicking "Save Spanning Tree", GeoDa will save the spanning tree as a GWT weights file. This weights file has the information of "the number of neighbors";
By clicking "Run" button, GeoDa will saves "CL" into current table as a new column.

@jkoschinsky jkoschinsky assigned Ashitacarl and unassigned lixun910 Dec 19, 2018
@lixun910
Copy link
Member

@Ashitacarl Do you have any other question re this issue?

By clicking "Save Spanning Tree", GeoDa will save the spanning tree as a GWT weights file. This weights file has the information of "the number of neighbors";
By clicking "Run" button, GeoDa will saves "CL" into current table as a new column.

@Ashitacarl
Copy link

@lixun910 Sorry that I forgot to reply on the issue.

I am just wondering how we can add the "number of neighbors" for each observation as a column in the table.

@lixun910
Copy link
Member

lixun910 commented Jan 14, 2019 via email

@Ashitacarl
Copy link

@lixun910 Great! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants