Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDBSCAN computing error #1785

Closed
lixun910 opened this issue Dec 17, 2018 · 2 comments
Closed

HDBSCAN computing error #1785

lixun910 opened this issue Dec 17, 2018 · 2 comments
Assignees
@lixun910
Labels
bug fixed: verify!

Comments

@lixun910
Copy link
Member

Found an error in HDBScan code when add auto-weighting function:

When compute the core-distances for each observation, the euclidean distance is used. However, the squared euclidean distance is used when search neighbors. This is wrong, and makes the parameter "Min samples", which defines the core-distance always "smaller".
@lixun910 lixun910 self-assigned this Dec 17, 2018
@lixun910 lixun910 added the bug label Dec 17, 2018
lixun910 added a commit to lixun910/geoda that referenced this issue Dec 17, 2018
@lixun910
add auto-weighting in HDBSCAN
aab232f 
also fix the issue in HDBSCAN computing error GeoDaCenter#1785
@lixun910 lixun910 mentioned this issue Dec 19, 2018
Merged
@lixun910
Copy link
Member Author

verified by comparing with HDBSCAN python library:
screen shot 2019-01-14 at 9 32 27 pm

@lixun910
Copy link
Member Author

testing data attached
test.csv.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lixun910 lixun910

Labels
bug fixed: verify!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lixun910 @jkoschinsky