Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi layer: pan seems to break connection #1806

Closed
lanselin opened this issue Jan 25, 2019 · 7 comments
Closed

multi layer: pan seems to break connection #1806

lanselin opened this issue Jan 25, 2019 · 7 comments
Assignees

Comments

@lanselin
Copy link
Collaborator

Panning seems to break the connection between the two layers (v 193). As with the previous issue, it is hart to tell what exactly triggered this, but after changing the outline color (and switching between outlines and boundary only), I used panning to move around. The result it that the point layer (the main layer) moved, but the polygon layer did not (see screen shot). The points should be on top of the polygons, not way above them.

screen shot 2019-01-25 at 10 31 49 am

lixun910 added a commit to lixun910/geoda that referenced this issue Jan 26, 2019
It is caused by a wrong condition checker in a new class GdaShapeLayer for multi-layer function:

The actual flag "IsShowBoundary()" should be used instead of the object instance "map_boundary".
@lixun910
Copy link
Member

lixun910 commented Feb 4, 2019

V195

@jkoschinsky jkoschinsky assigned Ashitacarl and bsalas11 and unassigned lixun910 Feb 4, 2019
@Ashitacarl
Copy link

GeoDa 1.12.1.195 (macOS Mojave, 10.14.1). Jan. 25 build.

Fix verified. Panning after [switching between boundaries and outlines] does not cause any problem for: 1) with and without basemap; 2) none/any/all of the layer is disabled while I do panning; 3) more than two layers.

1806

@lixun910
Copy link
Member

This issue still exists when load multiple layers with different projections: e.g. first layer is EPSG 4269 and second layer is EPSG3857.

@lixun910 lixun910 reopened this Mar 23, 2019
lixun910 added a commit to lixun910/geoda that referenced this issue Mar 23, 2019
…with different projections

This issue still exists when load multiple layers with different projections: e.g. first layer is EPSG 4269 and second layer is EPSG3857.
@lixun910
Copy link
Member

lixun910 commented Mar 28, 2019

Add "Projection (proj4)" information in Project Information dialog. Also allow a user to copy the content in Project Information dialog

Screen Shot 2019-03-29 at 11 13 04 AM

@lixun910
Copy link
Member

lixun910 commented Mar 29, 2019

Allow a user to set CRS (projection) when saving a data source. The CRS is in Proj4 format and can be changed manually. If a user is not familiar with CRS, he/she can use the "earth" button to load CRS (projection) from other data source:

Screen Shot 2019-03-29 at 11 18 14 AM

@lixun910 lixun910 assigned lixun910 and unassigned Ashitacarl and bsalas11 Mar 29, 2019
lixun910 added a commit to lixun910/geoda that referenced this issue Mar 29, 2019
1. Add "Projection (proj4)" information in Project Information dialog. Also allow a user to copy the content in Project Information dialog
2. Allow a user to set CRS (projection) when saving a data source. The CRS is in Proj4 format and can be changed manually. If a user doesn't familiar with CRS, he/she can use the "earth" button to load CRS (projection) from other data source
@lixun910
Copy link
Member

V219

@jkoschinsky jkoschinsky assigned Ashitacarl and unassigned lixun910 Mar 29, 2019
@lixun910 lixun910 mentioned this issue May 16, 2019
@lixun910
Copy link
Member

lixun910 commented Aug 2, 2019

Fix verified on Mac and Ubuntu 18.04.

Screen Shot 2019-08-02 at 11 51 14 AM

Screen Shot 2019-08-02 at 11 53 18 AM

@lixun910 lixun910 closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants