Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash related to field names with merged tables #1861

Closed
jkoschinsky opened this issue May 1, 2019 · 2 comments
Closed

crash related to field names with merged tables #1861

jkoschinsky opened this issue May 1, 2019 · 2 comments
Assignees
@lixun910
Labels
Crash: Replicate fixed: verify! Module-Table

Comments

@jkoschinsky
Copy link
Collaborator

Finally caught one of the table field name crashes in action.

Steps:

  • load csv with XY (map displayed)
  • merge this with another XY with duplicate field names
  • when trying to save as csv field creation error is displayed and it won't let you save
  • when saving as shapefile, it displays the field name dialog to correct the names
  • after correcting the names, GeoDa crashes

Note: in the file that's merged, the ID field is blank.

will send you the files separately since they're non-public
@jkoschinsky
Copy link
Collaborator Author

Tested again and it works once I add the missing field name, so crash is due to blank field name (and I had saved map before merging in case that's related).

lixun910 added a commit to lixun910/geoda that referenced this issue May 1, 2019
@lixun910
GeoDaCenter#1861
4d81502
lixun910 added a commit to lixun910/geoda that referenced this issue May 1, 2019
@lixun910
GeoDaCenter#1861 update fix for table manipulation
f4a792e 
□make sure field name can be changed to upper/lower case, e.g. ID->id or id->ID
□make sure no duplicate field name (case insensitive e.g. ID and id) can be added in a table
□raise warning when load a CSV file with duplicate field names
□ merge a CSV file with a field name that is duplicated in original CSV file
□ make sure field works with plots/maps after changing field name
lixun910 added a commit to lixun910/geoda that referenced this issue May 2, 2019
@lixun910
update fix for GeoDaCenter#1861 GeoDaCenter#1862 for time grouped var…
d2c5d7e 
…iables
@lixun910 lixun910 mentioned this issue May 16, 2019
Merged
@lixun910
Copy link
Member

lixun910 commented Aug 2, 2019

Fix verified by Julia, and Xun (on Mac and Ubuntu).

@lixun910 lixun910 closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lixun910 lixun910

Labels
Crash: Replicate fixed: verify! Module-Table
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lixun910 @jkoschinsky