Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rook weights not sensitive to precision threshold #462

Closed
lanselin opened this issue Aug 24, 2016 · 1 comment
Closed

rook weights not sensitive to precision threshold #462

lanselin opened this issue Aug 24, 2016 · 1 comment
Labels
bug fixed: verify! Milestone-Release1.8

Comments

@lanselin
Copy link
Collaborator

The Rook weights construction does not seem to be sensitive to the Precision Threshold. For example, using the NYC sub borough example, where there is a know digitizing problem, the Queen contiguity works fine with the Precision threshold at the default 0.0001, but the Rook contiguity fails, even with a threshold of 0.1 (as shown on image) or even 1.

screen shot 2016-08-24 at 9 26 04 am
lixun910 referenced this issue in lixun910/geoda Aug 26, 2016
@lixun910
#462 rook weights with precision threshold
fcc114a 
This fix is applied precision threshold to rook weights — when detect
sharing edge, the precision threshold is not used in rook weights
creation.
@jkoschinsky
Copy link
Collaborator

works now:

screen shot 2016-08-31 at 12 45 05 pm

This was referenced Sep 2, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed: verify! Milestone-Release1.8
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lixun910 @lanselin @jkoschinsky