Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with GEOJson custom map #67

Closed
chalbin73 opened this issue Nov 29, 2020 · 5 comments · Fixed by #69
Closed

Problem with GEOJson custom map #67

chalbin73 opened this issue Nov 29, 2020 · 5 comments · Fixed by #69
Assignees
Labels
random-algorithm Algorithme pick randoms position

Comments

@chalbin73
Copy link

Hello,
I came accros a little problem while playing your game. I wanted to play in my own city, so I created a custom GEOJson with polygon around my city. I launched the game and i had this messages "Nearby Position : Unfortunately, we were unable to find a random position in the defined location. However, we have found one nearby 😉". I'm sure that the StreetView car went through my city : i tested with waypoints it worked.

Thank you very much !
Albin

@BilelJegham
Copy link
Member

Hi,
It's link to small city with large not "street view" area.
The algorithm pick an random position in polygon and find the closest place streetviewed. If the place aren't in the polygon, it repeat the operation. Maximum 3 times, else it print the message "Nearby Position".

An example, a village (5.16 m²) near a river. The position pick is generally on the other side of the river.
image
Google Map link : https://goo.gl/maps/mbUmUefmdLQMrNrF9

Does it's criteria match with your city?

I advise you to make your maps with point and not polygon 😉. In the future, we should take the time to change the algorithm.

@BilelJegham BilelJegham added the random-algorithm Algorithme pick randoms position label Nov 30, 2020
@chalbin73
Copy link
Author

Hi,
I don't think that this is the case. I made a little test :
First, i selected a small area with only roads in it and I made sure that there is a lot of other roads around the polygon (of course all the roads are streetviewed) :
MAP1
This is the area that i selected (not a lot of empty spaces in the polygon and some roads arround)
MAP2
And this is the place where I spawn on all rounds (I marked it with a waypoint)
There is a lot of roads beetween the polygon and the waypoint.
Google map : https://goo.gl/maps/CUvaHp2Wkoc65QQ19
And the GEOJson that I used : http://pastebin.fr/75928 (The point in it is the place where I spawn at each rounds)

Thank you for your fast answer !

@BilelJegham
Copy link
Member

BilelJegham commented Dec 14, 2020

Sorry for the delay,

I thinks I find where is the problem.

We define the panorama search with a radius of 100km. 😅

I will test to change this week.
https://github.com/GeoGuess/Geoguess/blob/68ccad6d183a558d43394321e88a0759a27bb7b0/src/pages/StreetView.vue#L165

@BilelJegham
Copy link
Member

It's finally fix 😃

Can you check it's good for you on : https://deploy-preview-69--geoguess2.netlify.app/

Thank you in advance.

@all-contributors please add @chalbin73 for bug

@allcontributors
Copy link
Contributor

@BilelJegham

I've put up a pull request to add @chalbin73! 🎉

BilelJegham added a commit that referenced this issue Dec 20, 2020
Fixs #67 Streetview search radius + #68 Firebase config
@BilelJegham BilelJegham mentioned this issue Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
random-algorithm Algorithme pick randoms position
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants